Fix type declaration mismatch in scalar stub #1190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds type declarations to the scalar type class stub generated by the
make:graphql:scalarcommand.The
ScalarTypeclass uses theNamedTypeImplementationtrait, which declares the following typed properties:https://github.com/webonyx/graphql-php/blob/master/src/Type/Definition/NamedTypeImplementation.php#L10-L12
However, the current
scalar.stubgenerates classes without type declarations, causing the following Fatal errors:Added type declarations to the stub file
src/Console/stubs/scalar.stubso that generated scalar type classes satisfy the parent class's type requirements:Type of change:
Checklist:
composer fix-style